[Difx-users] The problem of root_id, again, please

[Geoff Crew]

We made a decision not to provide ambiguous root codes, so you
should migrate to the newer version of difx2mark4 at your convenience.

-- 

		Geoff (gbc at haystack.mit.edu)

On Fri, Feb 08, 2019 at 05:45:03PM +0300, Alexey Melnikov wrote:
> Dear all,
> 
> Unfortunately, when that topic arise on the mail list, I have used another
> email to send my solution (as a patch-file) and nobody received it. I want to fix this.
> 
> The solution in the latest DiFX code is too complex.
> 
> If somebody read the commentary text in the root_id.c file, he/she can learn
> that "...unique code consisting of 6 lower-case alphabetic characters a-z. ..."
> 
> and in the function there are chars code[5] to code [0] got the new values
> from current seconds number. For me, according to the commentary above and the
> comment in the line "code[1] = 'a' + (elasped/456979) % 26;  /* 0 --> 'aaaaaa'
> */", it is obvious that there was made a simple typo in the code, on the next
> line the author forgot to put "% 26;".
> 
> So the correct line should be "code[0] = 'a' + (elasped/11881376) % 26;"
> 
> I made this changes to my difx2mark4 source and hops's source and I am happy.
> In case of using the latest solution of DiFX code one can get the problems with different
> versions of hops/difx.
> 
> -- 
> Best regards,
> Alexey Melnikov
> 
> 
> Please avoid sending me Word or PowerPoint attachments.
> See http://www.gnu.org/philosophy/no-word-attachments.html
> 
> _______________________________________________
> Difx-users mailing list
> Difx-users at listmgr.nrao.edu
> https://listmgr.nrao.edu/mailman/listinfo/difx-users
> 
> !DSPAM:5c5d962e241841088119740!