[daip] Serious mnj bug!!

[Chris Flatters]

> The err file says
> $ more UPD20000713.ERR                             
> UPDCOPYSUB: Copy of /AIPS/31DEC99/APL/PGM/NOTST/AFILE.FOR
> UPDCOPYSUB: to      ohsumi:/AIPS/31DEC99/APL/PGM/NOTST/AFILE.FOR
> UPDCOPYSUB: failed after 5 attempts.
> $ 
> 
> This makes me think that we cannot depend on any of the current
> contents of the source code anywhere.  I would guess that the
> "restoring" operation resets the error code so that the higher level
> proc does not know that UPDCOPYSUB has failed.

Apparently not. UPDCOPYSUB sets a variable (Status) to a non-zero value
after it writes this message and before trying to copy back the .old
file. It uses this value in the exit statement so that it is available
to UPDCOPY as $? immediately following the call to UPDCOPYSUB.

I think that the problem is a few lines further down in UPDCOPY with

            elif [ $Status != OK ] ; then
               Status=OK
            fi

I think that this means that the final status of UPDCOPY is the status
of the last UPDCOPYSUB when it should be the conjunction of the results
of all the UPDCOPYSUBS. I think that dropping this elif branch will
probably solve the problem.	

	Chris Flatters
	cflatter at nrao.edu