[Difx-users] difx2mark4 bug {External}

[Geoffrey B. Crew]

John (in CC) was looking at the issue, and as you've discovered, it's 
not quite as trivial as you thought.

My recollection is that it is in fact a "standard" that two-letter codes 
have this camel case (first letter upper and second lower) convention, 
but I don't know how strict that is. Clearly the difx2mark4 code is 
trying to be correct here.

A confusing issue (to me anyway) is that the vex2difx process seems to 
elevate both to uppercase which I suspect is for historical reasons 
(rather than an optimal design choice).

Anyway, if you can modify your vex to use 'Jl' rather than 'JL' you 
should have no issues.

On 2/12/24 17:29, Alexey Melnikov via Difx-users wrote:
> Dear all,
>
> I need to withdraw my patch (it broke other cases) and ask for advise. In
> DiFX *.input files all 2-symbol station names are converted to capitals
> dispite how they were written in *.vex.
>
> In my particular case, difx2mark4 fails since I have station named in capitals
> in vex, like 'JL'. So after line of code patched in my patch in turns out to
> 'Jl' and ovex file become wrong.
>
> Does it mean that the better solution would be to keep 2-symbol station names
> in capitals when executing difx2mark4? Of course, another solution is to keep
> 2-symbol station names in sched's station.dat file as 'Jl', not 'JL'.
>
> regards,
> Alexey
>
>
>
> On 20240212 17:57:56, Adam Deller via Difx-users wrote:
>> Thanks, Alexey.
>>
>> Hopefully someone from Haystack (Geoff, John?) could take a look at this
>> and merge if happy? We should aim to get a new release off the git repo in
>> the not too distant future, as the number of small bugs fixed is starting
>> to stack up.
>>
>> Cheers,
>> Adam
>>
>> On Mon, 12 Feb 2024 at 11:57, Alexey Melnikov via Difx-users <
>> difx-users at listmgr.nrao.edu> wrote:
>>
>>> Dear DiFX community,
>>>
>>> A few days ago I got an annoying bug in the difx2mark4. In my case I have
>>> station in the vex file with 2-symbol code in capitals (say 'JL'), after
>>> correlation I have run difx2mark4 and got an error in the root file for
>>> this
>>> station. In occures that somebody converts 2-nd symbol of station name to
>>> lower case, what cause problem of different tags in the ovex file. Patch
>>> file
>>> and the path to that file in difx2mark4 source code are attached.
>>>
>>> Can somebody help to review patch and incorporate it to the codebase? All
>>> latest master_tag versions are affected, but there is only single release
>>> in
>>> git, so, I think I need somebody who knows what to do.
>>>
>>> regards,
>>> Alexey
>>>
>>> --
>>> Best regards,
>>> Alexey Melnikov, Scientific Researcher
>>> Laboratory of Radio Astronomy Observations
>>> The Institute of Applied Astronomy RAS
>>> St.-Petersburg, Russia, tel. +7 (812) 2751106
>>>
>>>
>>> Please avoid sending me Word or PowerPoint attachments.
>>> See http://www.gnu.org/philosophy/no-word-attachments.html
>>> _______________________________________________
>>> Difx-users mailing list
>>> Difx-users at listmgr.nrao.edu
>>> https://listmgr.nrao.edu/mailman/listinfo/difx-users
>>>
>>
>> -- 
>> !=============================================================!
>> Prof. Adam Deller
>> Centre for Astrophysics & Supercomputing
>> Swinburne University of Technology
>> John St, Hawthorn VIC 3122 Australia
>> phone: +61 3 9214 5307
>> fax: +61 3 9214 8797
>> !=============================================================!
>> _______________________________________________
>> Difx-users mailing list
>> Difx-users at listmgr.nrao.edu
>> https://listmgr.nrao.edu/mailman/listinfo/difx-users
>
-- 
Geoff Crew
MIT Haystack Observatory
gbc at mit.edu
(NOTE NEW EMAIL: gbc at haystack is no longer reliable)